search

ueberauth / ueberauth_slack

Slack OAuth2 Strategy for Überauth
MIT License
23 stars 33 forks source link

Check users read scope before requesting #21

Closed cjab closed 6 years ago

cjab commented 6 years ago

This builds on work by @prashanthsadasivan. I've just rebased the original PR #18 and handled the cases in which we're assuming that the slack user info exists.

One problem with this is that e-mail is the default uid field and without users:read it will be nil. For my use case this isn't a big deal but I'm not sure what the larger consequences are. We do still have a user id and user name from the /auth.test response that could be used as a uid. The info struct doesn't have an id field though so I'm not sure where an id would go and a user name isn't necessarily unique.

alvincrespo commented 6 years ago

@doomspork Anything I can do to help get this into master?

doomspork commented 6 years ago

Thank you @cjab and @alvincrespo. Apologizes for the delays I've been away for sometime.