Enable configurable redirect_uri

[alvincrespo]

I'm currently using this lib in a JSON based API. The single page app (SPA) set's a redirect_uri that is a route to the SPA instead of the API so that the UI can do some other requests. This library currently assumes the redirect_uri is relative to the SPA, which doesn't fit my current use case.

The change here is to allow the developer to specify this redirect_uri from a config Keyword list.

Changes

• Checks for redirect_uri key in the Ueberauth config
  • if it exists, we use that value
  • if it does not exist, we use the default from client_options

Question

• Should this redirect_uri be configurable on config :ueberauth, Ueberauth.Strategy.Slack.OAuth or config :ueberauth, Ueberauth?

[alvincrespo]

@doomspork Curious what your thoughts are here?

PS. Not sure if you're the person to ping here, if not please point me in the right direction.

[alvincrespo]

I moved this to the slack strategy so that it's easier to read - I think this is the place it probably belonged first.

[doomspork]

Sorry for the delays @alvincrespo, I've been away. For future reference, there is a @ueberauth/developers team you can ping 😁

[alvincrespo]

@doomspork Thanks for the review! @ueberauth/developers Ready for another round of review.

[alvincrespo]

Ah, looks like I don't have access to use @ueberauth/developers handle.

[alvincrespo]

@doomspork Just wanted to see if there was anything I could do to move this forward?

[doomspork]

Thank you @alvincrespo 👍

I will cut ueberauth/guardian releases later this week. In the meantime you can point to master:

{:ueberauth_slack, github: "ueberauth/ueberauth_slack"}

[alvincrespo]

@doomspork w00t! Thanks for your help 😄