search

ueberauth / ueberauth_slack

Slack OAuth2 Strategy for Überauth
MIT License
23 stars 33 forks source link

Extract images and team domain from identity only auth #33

Closed ibash closed 4 years ago

ibash commented 5 years ago

When using sign in with slack the team domain and image urls are provided. This pulls them out into info and credentials.

ibash commented 5 years ago

@tajchumber I'm still fairly new to elixir, are my changes idiomatic?

taj commented 5 years ago

@ibash don't worry about it :) the PR looks good!

ibash commented 5 years ago

@Hanspagh I don't think so, because the identity object comes when using the "sign in with slack" api, vs user comes from "add to slack" api.

ibash commented 5 years ago

@Hanspagh @doomspork updated!

Hanspagh commented 4 years ago

Looks good to me @doomspork ?