Improve OAuth error handling

ueberauth / ueberauth_twitter

Twitter Strategy for Überauth

MIT License

36 stars 38 forks source link

Improve OAuth error handling #10

Closed jbrowning closed 7 years ago

jbrowning commented 7 years ago

Fixes a crash on network error in access_token!/2 and request_token!/2
Fixes a crash when an API request results in a non-200 status

Ideally this would raise an error-specific exception instead of the default RuntimeError but I think it's best to err on the side of backwards-compatibility. I've also created a test for OAuth that only tests for this issue but which could (should :wink:) include more extensive tests in the future.

Fixes #8

doomspork commented 7 years ago

Thank you @jbrowning! Improving tests for strategies is something we've been discussing for awhile.