search

ueberauth / ueberauth_twitter

Twitter Strategy for Überauth
MIT License
36 stars 38 forks source link

Switch to native Elixir dependency for OAuth #14

Closed gwbrown closed 7 years ago

gwbrown commented 7 years ago

The erlang-oauth dependency causes some issues:

  1. It's not available through Hex, so it requires the user to add a separate GitHub dependency.
  2. It relies on Make, and so does not build smoothly on Windows.

The changes in this PR change the code to use OAuther instead of erlang-oauth, which resolves the issues above.

These changes also clear up the Elixir 1.4 warnings.

doomspork commented 7 years ago

Thank you @gwbrown! I'll look through this today and leave feedback 👍

gwbrown commented 7 years ago

Thanks for the review! I'll go through and clean it up soon - either after work today or sometime this weekend.

gwbrown commented 7 years ago

Made the changes requested above.

doomspork commented 7 years ago

Thank you @gwbrown!! I'll look this over and merge it today 👍

doomspork commented 7 years ago

Thank you @gwbrown 👍