ueberauth / ueberauth_twitter

Twitter Strategy for รœberauth
MIT License
36 stars 38 forks source link

Bump httpoison to 1.0 #22

Closed jerodsanto closed 6 years ago

jerodsanto commented 6 years ago

๐Ÿ‘‹ we use ueberauth_twitter on changelog.com (repo), thanks!

I'd like to upgrade our site to httpoison 1+, but this dep is locked down a bit so I can't.

This commit upgrades to ~> 1.0, which is what the httpoison readme suggests to do. All tests are green.

I'd also be cool with using >= 0.13 if you'd prefer, but 1.0 appears to be a-ok.

doomspork commented 6 years ago

@jerodsanto have you tested this to ensure it works? If so we can get this merged ๐Ÿ‘

For future reference you can do this in your mix file:

{:httpoison, "~> 1.0", override: true}
jerodsanto commented 6 years ago

@doomspork yup, works great! I've never seen the override option, very cool thanks for the knowledge! ๐Ÿ’š

doomspork commented 6 years ago

@jerodsanto thank you and you're welcome!