Pass provider options and query params to authorize_url

ueberauth / ueberauth_twitter

Twitter Strategy for Überauth

MIT License

36 stars 38 forks source link

Pass provider options and query params to authorize_url #38

Open ntilwalli opened 3 years ago

ntilwalli commented 3 years ago

This PR integrate changes from #32 and #34, fixes tests as well as passes provider options to authorize_url!. This allows the request url to be configured since Twitter offers both an /oauth/authorize and /oauth/authenticate endpoint. The former endpoint requires the user goes through the app permission workflow each time, latter endpoint allows users to authenticate once and not have to authorize on subsequent login attemps until they revoke access. See StackOverflow discussion here.

benvp commented 2 years ago

Are there any plans on merging this? Going through the "I authorize the app to do so" flow every login is a little cumbersome.

yordis commented 2 years ago

@benvp not sure if @ntilwalli is still interested in continuing the work. I can't take the workload at the very moment, so please take the lead and I will assist you as much as I can with it

benvp commented 2 years ago

Thanks for the reply. Will have a look and see how to bring this forward.