search

ueberauth / ueberauth_twitter

Twitter Strategy for Überauth
MIT License
36 stars 38 forks source link

Add Github Actions for CI, cont'd #47

Closed clupprich closed 3 years ago

clupprich commented 3 years ago

Based on https://github.com/ueberauth/ueberauth_twitter/pull/42, I've continued work here and made both the tests and Credo pass.

I'm not really sure about the error handling. I looked at other strategies, and they manage to get along without custom error modules and are also not raising errors, so I could use some guidance on how to make this better.

yordis commented 3 years ago

Thank you so much for the help! Really appreciate it!

clupprich commented 3 years ago

@yordis I'm happy to contribute - it's fun!