search

ueberauth / ueberauth_vk

vk.com OAuth2 Strategy for Überauth.
https://hex.pm/packages/ueberauth_vk
MIT License
19 stars 12 forks source link

Ability to set state #20

Closed Virviil closed 6 years ago

Virviil commented 6 years ago

VK has ability to pass you back any string, that is set inda "state" parameter.

This can be used to save "session_id" to prevent middle attacks on the auth process.

So, redirect into /auth/vk?state=<session_id> should work. After that, this state should be saved inside success struct

Virviil commented 6 years ago

I'm definitely need soome help with this changing, because don't understand the internal structure of success response because of lack of documentation

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 85.915% when pulling 209ab1ae6a7ba3f8e633e9bacba6e04b781ad550 on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 85.915% when pulling 209ab1ae6a7ba3f8e633e9bacba6e04b781ad550 on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

sobolevn commented 6 years ago

Sure! Maybe we should start with the falling test? I guess API and documentation could be changed, I have not updated this package in a while.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 85.915% when pulling ee20f5dac31611b485d4f0803799a2ff787f74ff on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 85.915% when pulling ee20f5dac31611b485d4f0803799a2ff787f74ff on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 85.915% when pulling ee20f5dac31611b485d4f0803799a2ff787f74ff on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-45.6%) to 40.278% when pulling 12eae4d8efd72b1262741664fb0d06065271952f on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-45.6%) to 40.278% when pulling 12eae4d8efd72b1262741664fb0d06065271952f on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 86.111% when pulling eb3130f5f9a563f028726eeb55d637551baef3fb on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 86.111% when pulling eb3130f5f9a563f028726eeb55d637551baef3fb on Virviil:adding-scope into 95a169d5d3c0a14c88a96cd78b6ab0d0a081d053 on sobolevn:master.

Virviil commented 6 years ago

Test were fixed. I've also tested how it's working in project.

@sobolevn, plz connect me via telegram: https://t.me/virviil

sobolevn commented 6 years ago

@Virviil thanks for your work!

Sorry, but I don't have a telegram account. We can chat in #elixirlang slack. My nickname is the same. You can also write me an email, if that more convenient to you.

sobolevn commented 6 years ago

Released! https://hex.pm/packages/ueberauth_vk