Fixed uid setting - Githubissues

ueberauth / ueberauth_vk

vk.com OAuth2 Strategy for Überauth.

https://hex.pm/packages/ueberauth_vk

MIT License

19 stars 12 forks source link

Fixed uid setting #4

Closed JustMikey closed 8 years ago

JustMikey commented 8 years ago

The uid field didn't get set, now it does. Hopefully I didn't break anything.

sobolevn commented 8 years ago

How to did you test it?

Sorry for the lack of unit-test. It is a problem for all ueberauth strategies, since the authors did not find any how-to-test solution yet.

JustMikey commented 8 years ago

Well, I did these changes and checked if it still worked and it did :) You should probably test it yourself anyway. It should be clear to you if those changes might have broken anything.

Maybe there is a better way to fix this, idk, it's up to you :)

sobolevn commented 8 years ago

You have found a bug, but it was in a totally different place. Anyway, thanks for the help!

JustMikey commented 8 years ago

Thanks to you :)