search

ueberdosis / pandoc

A PHP wrapper for Pandoc to convert any text format in any other text format
MIT License
77 stars 10 forks source link

Add option to set custom options #19

Closed cheryllium closed 3 years ago

cheryllium commented 3 years ago

For #15

cheryllium commented 3 years ago

@hanspagel ready for your review :)

maggie44 commented 3 years ago

Hi @cheryllium,

I may try giving this a whirl next week. Would be great if you could include a commit updating the docs on its use.

Thanks for taking this on.

maggie44 commented 3 years ago

I also see some of the options deemed common are in their own function. Do you see these as common? I note they are the same as from my post. I merely picked three random examples, I think the approach to be able to pass options more broadly like your first commit makes most sense. Not sure if the third commit is necessary, just wanted to flag that in case it was the result of my post.

cheryllium commented 3 years ago

@maggie0002 Yeah, I thought those were what you needed specifically, so that's why I added shortcuts for them.

I'd agree with reverting it then. @hanspagel do you want to weigh in?

I think wrappers around the generic function, like those, are nice to have but we probably want a better idea of which options would be most useful to have wrappers for first. I don't have any suggestions.

I'll add proper docs. Thanks for the reminder and other good thoughts!

cheryllium commented 3 years ago

@maggie0002 Hey, I won't have time to update this for a while. Would you like to write the documentation instead? You can add it to my fork (I think)

hanspagel commented 3 years ago

Thanks for your work on this! 🙌 I’ve merged it, fixed a minor mistake, added documentation and tagged a new version. ✌️