search

ueberdosis / tiptap-php

A PHP package to work with Tiptap content
https://tiptap.dev
MIT License
183 stars 28 forks source link

fix misaligned tags for overlapping marks #37

Closed faltjo closed 1 year ago

faltjo commented 1 year ago

This solves the issue with misaligned tags for overlapping marks, see https://github.com/ueberdosis/tiptap-php/issues/33

In order to preserve the correct order when closing and reopening html tags, a stack is used to track all currently open mark tags.

hivokas commented 1 year ago

It seems to be fixing https://github.com/ueberdosis/tiptap-php/issues/33 for me. Would be great to see it merged.

timoisik commented 1 year ago

Hey @faltjo, thanks for the PR. I will have a look as soon as possible. Need some time to take care of it though.

hivokas commented 1 year ago

Thank you @timoisik

hivokas commented 1 year ago

Thanks @faltjo for fix, and @timoisik for merging!