search

ueberdosis / tiptap

The headless rich text editor framework for web artisans.
https://tiptap.dev
MIT License
27.38k stars 2.28k forks source link

Vite Support #1124

Closed holtwick closed 3 years ago

holtwick commented 3 years ago

As Vue3 supports comes closer ueberdosis/tiptap-next#85 , don't forget about Vite support. Cannot live without it any more ;)

Maybe a nice starter template would attract more users as well? Something like npm init @tiptap/create similar to https://vitejs.dev/guide/#browser-support

I tried to set up something myself, but it is not trivial yet.

philippkuehn commented 3 years ago

Yeah, would be great. We already found this issue with y-prosemirror when using vite :/

holtwick commented 3 years ago

Indeed, that was an issue I ran into as well, which keeps me from migrating my project to vite yet...

hanspagel commented 3 years ago

Yes! Vite is amazing. ⚡️

I’m not sure about the npm init @tiptap/create thing. I don’t know what tech stack we’d use for that. Vue 2, 3, React? Vanilla? And I don’t think it’s worth to maintain all of them. 😏

Vite is pretty easy to set up though, and the default tiptap example, too. But we need to get Vue 3 support ready and iron out other glitches, like the one with y-prosemirror for Vite support, and we definitely want that too. 😅

holtwick commented 3 years ago

I provided a fix for https://github.com/yjs/y-prosemirror/issues/40 and can confirm it works smoothly on vite and your new vue3 support. Amazing work! Thanks.

@hanspagel I follow your argumentation and indeed, the create script is a not so important additional layer somebody needs to put work in. In general, it is all very self-explanatory.

holtwick commented 3 years ago

@dmonad applied a fix to y-prosemirror and published the new npm. Until the dependencies are updated in tiptap it can be worked around by installing y-prosemirror in the own project as well. Due to its internal structure Vite will use this version then.

hanspagel commented 3 years ago

That’s great news! 🙌 We’ll release a fresh version with updated depencies in the next days.

philippkuehn commented 3 years ago

released