ueberdosis / tiptap

The headless rich text editor framework for web artisans.
https://tiptap.dev
MIT License
26.35k stars 2.22k forks source link

Node following the end of a line should be removed and the text joined when Delete is pressed at the end of a line #3454

Open bdbch opened 1 year ago

bdbch commented 1 year ago

What’s the bug you are facing?

This comes from this comment: https://github.com/ueberdosis/tiptap/pull/3192#issuecomment-1245874803

Basically when you're at the end of a paragraph for example (but also happens with any other block with text content) and you press Delete, the following node doesn't get joined correctly.

Instead of the next text node being joined with the current text, the node on the next line gets removed but nothing happens with the content.

Which browser was this experienced in? Are any special extensions installed?

Chrome, Firefox

How can we reproduce the bug on our side?

  1. Create a paragraph, write some text
  2. Create a blockquote after the paragraph
  3. Place your cursor at the end of the paragraph
  4. Press Delete

Can you provide a CodeSandbox?

No response

What did you expect to happen?

When delete is pressed, the text content from the next line should be joined with the current text node and the next node should be removed (or the wrapper of the empty text node at least - since you could be in a list / nested node that shouldn't be removeD).

Anything to add? (optional)

No response

Did you update your dependencies?

Are you sponsoring us?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

bdbch commented 1 year ago

bump

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days