search

ueberdosis / tiptap

The headless rich text editor framework for web artisans.
https://tiptap.dev
MIT License
27.13k stars 2.26k forks source link

[Bug]: Link Extension Issue After Line Break in Google Chat #5335

Open giuseppeagostini-hotmart opened 3 months ago

giuseppeagostini-hotmart commented 3 months ago

Affected Packages

core, react

Version(s)

v2.0.4

Bug Description

https://github.com/user-attachments/assets/32d6a50e-851d-4206-af83-19eb63311ac6

Good afternoon, I am experiencing an issue, and it is also occurring on the tiptap platform(as shown in the video). Using Google Chat, I sent a test message to myself with two links, one from Google and one from Yahoo. The problem is as follows: when I have a link, followed by a line break, the link extends into the next word after the line break, making the link invalid.

First test: One: https://www.google.com/ Two: https://www.yahoo.com/

As shown in the video, in the above example, the first link generates an error because it concatenates the line break and the first word (two) into the link. However, in the example below, everything works correctly.

Second test: One: https://www.google.com/ x Two: https://www.yahoo.com/ y

Browser Used

Chrome

Code Example URL

https://templates.tiptap.dev/9PPbJz7h9d

Expected Behavior

After fixing this issue, links should not extend into the next word after a line break. Each link should remain valid and separate from any text following a line break. For instance, in the first test, the link to Google should remain as https://www.google.com, without including the word "Two" or any subsequent text. This behavior should be consistent regardless of the position of line breaks and surrounding text.

Additional Context (Optional)

No response

Dependency Updates

giuseppeagostini-hotmart commented 3 months ago

Is this the last version?

"@tiptap/extension-bubble-menu": "^2.5.1",
"@tiptap/extension-character-count": "^2.5.1",
"@tiptap/extension-floating-menu": "^2.5.1",
"@tiptap/extension-link": "^2.5.1",
"@tiptap/extension-placeholder": "^2.5.1",
"@tiptap/extension-underline": "^2.5.1",
"@tiptap/pm": "^2.5.1",
"@tiptap/react": "^2.5.1",
"@tiptap/starter-kit": "^2.5.1"

https://github.com/user-attachments/assets/cfdf3848-226b-4809-a064-03dcc0ebffef

Does the video editor always follow the latest version? As shown in the video, the error continues. I updated my application to 2.5.1, and the error also continues

giuseppeagostini-hotmart commented 3 months ago

Is this the last version?

***@***.***/extension-bubble-menu": "^2.5.1",
***@***.***/extension-character-count": "^2.5.1",
***@***.***/extension-floating-menu": "^2.5.1",
***@***.***/extension-link": "^2.5.1",
***@***.***/extension-placeholder": "^2.5.1",
***@***.***/extension-underline": "^2.5.1",
***@***.***/pm": "^2.5.1",
***@***.***/react": "^2.5.1",
***@***.***/starter-kit": "^2.5.1"

Does the video editor always follow the latest version? As shown in the video, the error continues. I updated my application to 2.5.1, and the error also continues

Video on github issue

On Mon, Jul 15, 2024 at 1:09 PM Jay2701 @.***> wrote:

The Bug is fixed it seems ?

— Reply to this email directly, view it on GitHub https://github.com/ueberdosis/tiptap/issues/5335#issuecomment-2228871492, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2HBNORYLOEODXPZ72OGP7LZMPX2XAVCNFSM6AAAAABKZPRIROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYHA3TCNBZGI . You are receiving this because you authored the thread.Message ID: @.***>

-- Giuseppe Fantoni

Front-end Developer +55 (31) 994440796

-- Esta mensagem de e-mail é para uso exclusivo do(s) destinatário(s) indicado(s) e pode conter informações legalmente privilegiadas, comercialmente sensíveis, privadas e/ou confidenciais. Se você não for o(s) destinatário(s) indicado(s), considere-se desde já notificado de que qualquer uso, divulgação, distribuição ou cópia não autorizada desta mensagem de e-mail ou seu conteúdo é estritamente proibido. Se você não for o destinatário indicado, comunique imediatamente o remetente por e-mail de resposta e destrua todas as cópias desta mensagem de e-mail.

This email message is for the sole use of the intended recipient(s) and may contain legally privileged, commercially sensitive, private, and/or confidential information. If you are not the intended recipient(s), you are hereby notified that any unauthorized use, disclosure, distribution, or copying of this email message or its contents is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply email and destroy all copies of this email message.