ueberdosis / tiptap

The headless rich text editor framework for web artisans.
https://tiptap.dev
MIT License
27.55k stars 2.29k forks source link

fix(core): onDrop and onPaste only registered when defined #5681 #5684

Closed nperez0111 closed 1 month ago

nperez0111 commented 1 month ago

Changes Overview

This updates the onDrop and onPaste event callbacks to only ever be registered if they exist on the editor instance at creation. It also refactors them to be extensions rather than separate Prosemirror plugins which would causes plugins to be destroyed and recreated immediately

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

Related Issues

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: dcacb0ea10616f6239fcee94a6a721e92da25a72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for tiptap-embed ready!

Name Link
Latest commit dcacb0ea10616f6239fcee94a6a721e92da25a72
Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66fa7b4d4937e5000829c1de
Deploy Preview https://deploy-preview-5684--tiptap-embed.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.