Add Node linebreakReplacement support and enable on hardBreak nodes

glenn-allen commented 1 week ago

Changes Overview

Support the linebreakReplacement property on Nodes
Set the hardBreak node as the linebreakReplacement node, by default.

Implementation Approach

Followed the way other properties are defined, such as whitespace

Testing Done

Added the property to hardBreak and verified in the local React CodeBlock example (http://localhost:3000/preview/Nodes/CodeBlock) that toggling from a codeBlock to a normal paragraph visually keeps the line breaks.

Before:

https://github.com/user-attachments/assets/4de1753d-6268-402b-b2ff-c8920a5a5f9f

After:

https://github.com/user-attachments/assets/cd0177e8-1586-498a-bdf6-09cd672ab20d

Verification Steps

In the CodeBlock example (tiptap/demos/src/Nodes/CodeBlock/React/index.jsx) add the HardBreak extension
Run and load the example - http://localhost:3000/preview/Nodes/CodeBlock
Verify that toggling off the codeBlock maintains the line breaks

Checklist

[ ] I have created a changeset for this PR if necessary.
[x] My changes do not break the library.
[ ] I have added tests where applicable.
[x] I have followed the project guidelines.
[x] I have fixed any lint issues.

Related Issues

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 35c2dcca01d1c1de2177e1e8dddbb592df9e8437

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages

| Name | Type | | -------------------------------------- | ----- | | @tiptap/core | Patch | | @tiptap/extension-hard-break | Patch | | @tiptap/extension-blockquote | Patch | | @tiptap/extension-bold | Patch | | @tiptap/extension-bubble-menu | Patch | | @tiptap/extension-bullet-list | Patch | | @tiptap/extension-character-count | Patch | | @tiptap/extension-code-block-lowlight | Patch | | @tiptap/extension-code-block | Patch | | @tiptap/extension-code | Patch | | @tiptap/extension-collaboration-cursor | Patch | | @tiptap/extension-collaboration | Patch | | @tiptap/extension-color | Patch | | @tiptap/extension-document | Patch | | @tiptap/extension-dropcursor | Patch | | @tiptap/extension-floating-menu | Patch | | @tiptap/extension-focus | Patch | | @tiptap/extension-font-family | Patch | | @tiptap/extension-gapcursor | Patch | | @tiptap/extension-heading | Patch | | @tiptap/extension-highlight | Patch | | @tiptap/extension-history | Patch | | @tiptap/extension-horizontal-rule | Patch | | @tiptap/extension-image | Patch | | @tiptap/extension-italic | Patch | | @tiptap/extension-link | Patch | | @tiptap/extension-list-item | Patch | | @tiptap/extension-list-keymap | Patch | | @tiptap/extension-mention | Patch | | @tiptap/extension-ordered-list | Patch | | @tiptap/extension-paragraph | Patch | | @tiptap/extension-placeholder | Patch | | @tiptap/extension-strike | Patch | | @tiptap/extension-subscript | Patch | | @tiptap/extension-superscript | Patch | | @tiptap/extension-table-cell | Patch | | @tiptap/extension-table-header | Patch | | @tiptap/extension-table-row | Patch | | @tiptap/extension-table | Patch | | @tiptap/extension-task-item | Patch | | @tiptap/extension-task-list | Patch | | @tiptap/extension-text-align | Patch | | @tiptap/extension-text-style | Patch | | @tiptap/extension-text | Patch | | @tiptap/extension-typography | Patch | | @tiptap/extension-underline | Patch | | @tiptap/extension-youtube | Patch | | @tiptap/html | Patch | | @tiptap/pm | Patch | | @tiptap/react | Patch | | @tiptap/starter-kit | Patch | | @tiptap/suggestion | Patch | | @tiptap/vue-2 | Patch | | @tiptap/vue-3 | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 week ago

Deploy Preview for tiptap-embed ready!

Name	Link
Latest commit	35c2dcca01d1c1de2177e1e8dddbb592df9e8437
Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/6731b9a293f1d800086755fe
Deploy Preview	https://deploy-preview-5821--tiptap-embed.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ueberdosis / tiptap