Prevent null pointer exception in `BubbleMenu`

felixgabler commented 4 days ago

Changes Overview

Our sentry is full of "Cannot read properties of null (reading 'dataset')" which point to this place in the getReferenceClientRect for tippy in the BubbleMenu extension. This PR just adds an additional nullability check.

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

[ ] I have created a changeset for this PR if necessary.
[x] My changes do not break the library.
[ ] I have added tests where applicable.
[ ] I have followed the project guidelines.
[ ] I have fixed any lint issues.

Related Issues

netlify[bot] commented 4 days ago

Deploy Preview for tiptap-embed ready!

Name	Link
Latest commit	49251b5ad95830c0331b91ab97c4c786b50f6a0d
Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/673bf7405a40540008edc1ab
Deploy Preview	https://deploy-preview-5842--tiptap-embed.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

changeset-bot[bot] commented 4 days ago

🦋 Changeset detected

Latest commit: 49251b5ad95830c0331b91ab97c4c786b50f6a0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages

| Name | Type | | -------------------------------------- | ----- | | @tiptap/extension-bubble-menu | Patch | | @tiptap/core | Patch | | @tiptap/extension-blockquote | Patch | | @tiptap/extension-bold | Patch | | @tiptap/extension-bullet-list | Patch | | @tiptap/extension-character-count | Patch | | @tiptap/extension-code-block-lowlight | Patch | | @tiptap/extension-code-block | Patch | | @tiptap/extension-code | Patch | | @tiptap/extension-collaboration-cursor | Patch | | @tiptap/extension-collaboration | Patch | | @tiptap/extension-color | Patch | | @tiptap/extension-document | Patch | | @tiptap/extension-dropcursor | Patch | | @tiptap/extension-floating-menu | Patch | | @tiptap/extension-focus | Patch | | @tiptap/extension-font-family | Patch | | @tiptap/extension-gapcursor | Patch | | @tiptap/extension-hard-break | Patch | | @tiptap/extension-heading | Patch | | @tiptap/extension-highlight | Patch | | @tiptap/extension-history | Patch | | @tiptap/extension-horizontal-rule | Patch | | @tiptap/extension-image | Patch | | @tiptap/extension-italic | Patch | | @tiptap/extension-link | Patch | | @tiptap/extension-list-item | Patch | | @tiptap/extension-list-keymap | Patch | | @tiptap/extension-mention | Patch | | @tiptap/extension-ordered-list | Patch | | @tiptap/extension-paragraph | Patch | | @tiptap/extension-placeholder | Patch | | @tiptap/extension-strike | Patch | | @tiptap/extension-subscript | Patch | | @tiptap/extension-superscript | Patch | | @tiptap/extension-table-cell | Patch | | @tiptap/extension-table-header | Patch | | @tiptap/extension-table-row | Patch | | @tiptap/extension-table | Patch | | @tiptap/extension-task-item | Patch | | @tiptap/extension-task-list | Patch | | @tiptap/extension-text-align | Patch | | @tiptap/extension-text-style | Patch | | @tiptap/extension-text | Patch | | @tiptap/extension-typography | Patch | | @tiptap/extension-underline | Patch | | @tiptap/extension-youtube | Patch | | @tiptap/html | Patch | | @tiptap/pm | Patch | | @tiptap/react | Patch | | @tiptap/starter-kit | Patch | | @tiptap/suggestion | Patch | | @tiptap/vue-2 | Patch | | @tiptap/vue-3 | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ueberdosis / tiptap