ueberdosis / tiptap

The headless rich text editor framework for web artisans.
https://tiptap.dev
MIT License
27.63k stars 2.3k forks source link

fix(link): change type HTMLLinkElement to HTMLAnchorElement #5858

Closed hungtcs closed 20 hours ago

hungtcs commented 1 day ago

Changes Overview

Fix the type assertion of file packages/extension-link/src/helpers/clickHandler.ts

Implementation Approach

Testing Done

Verification Steps

Additional Notes

The HTMLLinkElement interface represents reference information for external resources and the relationship of those resources to a document and vice versa (corresponds to link element; not to be confused with a, which is represented by HTMLAnchorElement). This object inherits all of the properties and methods of the HTMLElement interface.

Checklist

Related Issues

changeset-bot[bot] commented 1 day ago

⚠️ No Changeset found

Latest commit: 161d1790568ae6ee31256273ed62657fdf4d1ab1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 day ago

Deploy Preview for tiptap-embed ready!

Name Link
Latest commit 161d1790568ae6ee31256273ed62657fdf4d1ab1
Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/673fecfbe3d02600084c9293
Deploy Preview https://deploy-preview-5858--tiptap-embed.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.