search

uecode / qpush-bundle

Asynchronous processing for Symfony using Push Queues
qpush-bundle.readthedocs.org
Apache License 2.0
168 stars 54 forks source link

Add fifo queue support #120

Closed mumia closed 7 years ago

mumia commented 7 years ago

Adds support for creating/destroying/publishing/receiving messages to and from an AWS FIFO Queue

tlfbrito commented 7 years ago

@kmfk Can you review this implementation please?

k-k commented 7 years ago

@mumia I was a little quick to merge that last PR (#117), I just resolved the conflict I created by doing so

scrutinizer-notifier commented 7 years ago

The inspection completed: 3 updated code elements

francoispluchino commented 7 years ago

@mumia Thanks for your work, however, there is a little bug with the push notification and FIFO queue. You can see the PR #124 for the fix.

mumia commented 7 years ago

@francoispluchino It seems I mislead you with my implementation. SNS topic subscription is not currently support by AWS for FIFO Queues. Check the "Compatibility" section on: http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html

I will write a fix for my PR removing the push notification support on fifo queues.

francoispluchino commented 7 years ago

Indeed, the doc isn't updated regarding the regions available, but SNS is still not available with SQS FIFO. Thanks for your precision.

On the other hand, my PR fixes the error 400 Invalid parameter: Topic Name.