uecode / qpush-bundle

Asynchronous processing for Symfony using Push Queues
qpush-bundle.readthedocs.org
Apache License 2.0
168 stars 54 forks source link

Implementing 'push_notifications_only' config :: Aws Only for now #136

Open 2Taps opened 7 years ago

2Taps commented 7 years ago

Hey guys,

With this i have tried to implement a configuration parameter that allow me to use the bundle and aws provider only with the SNS to push messages to my backend, without SQS.

I know that SNS have the maximum retention time of 1 hour for messages but this is ok for my use case.

I also want to make the bundle able to configure/atach a delivery policy to be able to configure 'notification_retries' and 'retry_timeout' but until now i do not know how to do it.

If someone can help would be nice. Until i am able to do this, ill manually configure the delivery policy in SNS dashboard.

Please let me now if you find some problem with my changes.

Thank you!

scrutinizer-notifier commented 7 years ago

The inspection completed: 1 new issues

2Taps commented 7 years ago

Maybe a better name for the option would be push_notifications_no_poll

k-k commented 6 years ago

@GuilhermeMoura1 I'm not sure if this would be a great idea, the point of the SQS queue was for the visibility timeout - since all subscribers are notified of the SNS message, it was a way to avoid having service workers from processing the same message concurrently.

If you remove SQS, you'd need to handle that situation yourself. Is that intended?

2Taps commented 6 years ago

Hey Guys,

We subscribe one endpoint of our backend to SNS. So SNS notify that endpoint and we have a load balancer in front that to direct the message to one of our webserver machines.