uecode / qpush-bundle

Asynchronous processing for Symfony using Push Queues
qpush-bundle.readthedocs.org
Apache License 2.0
168 stars 54 forks source link

Update composer.json to include version 4.0 for symfony libraries #137

Closed nfabre closed 6 years ago

nfabre commented 6 years ago
RomulusED69 commented 6 years ago

Any idea when this PR will be available ? @nfabre @francoispluchino

tristanbes commented 6 years ago

Yes, we would need it too. :-)

francoispluchino commented 6 years ago

@RomulusED69 I don't have access to the repository with the write permissions, so I cannot do much... But I also need this PR to pass a project in 4.0.

tristanbes commented 6 years ago

ping @kmfk

nfabre commented 6 years ago

I think this bundle will be deprecated with the new Symfony's Messenger composant. http://symfony.com/blog/new-in-symfony-4-1-messenger-component

tristanbes commented 6 years ago

I hope not, because IronMQ is not suppported neither by the new component, neither by the bridge, neither by php-enqueue/enqueue-dev

I've just opened an issue for it. https://github.com/php-enqueue/enqueue-dev/issues/415

k-k commented 6 years ago

Hello. So, reviewing the PRs, the issues with the broken builds etc, it made most sense to drop support for php 5.4 and 5.5 - was going to do this in a new major version (including this PR).

However, I haven't had the opportunity to work in a symfony project in a few years now and have done a pretty poor job keeping up on this repo.

If I were to transfer this to a new org, anyone here interested in helping to maintain it?

scrutinizer-notifier commented 6 years ago

The inspection completed: No new issues

cryptiklemur commented 6 years ago

Is there a particular reason to not file a pull request or feature request with symfony/messenger to support IronMQ @tristanbes ?

tristanbes commented 6 years ago

As I understand it, the messenger component use the enqueue bundle and library and it’s not supported yet. I’ve opened an issue there but we got some project using this library

Envoyé de mon iPhone

Le 28 mars 2018 à 21:05, Aaron Scherer notifications@github.com a écrit :

Is there a particular reason to not file a pull request or feature request with symfony/messenger to support IronMQ @tristanbes ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

k-k commented 6 years ago

@nfabre @tristanbes I tagged v3.0

francoispluchino commented 6 years ago

@kmfk The tag v3.0 is not synchronized with the Packagist.org service.

k-k commented 6 years ago

@francoispluchino Fixed. Looks like Packagist started validating the license text in the composer.json and mine was missing a hyphen.

francoispluchino commented 6 years ago

Great! But I just saw an another problem: why this constraint for symfony/config: ~2.3|^3.0? While the others dependencies have the ^4.0.

k-k commented 6 years ago

Huh. I saw that while fixing a merge conflict from another PR, but noticed that the original commit in this PR had also left it that way. I'm guessing that needs to be bumped as well?

francoispluchino commented 6 years ago

Yes.