search

uehaj2022 / latteart

Apache License 2.0
0 stars 6 forks source link

fix uehaj2022 / latteart#21 #24

Closed kushagra20251 closed 1 year ago

kushagra20251 commented 1 year ago

Confirmation dialog Box for pausing and resuming capture tool. adding a confirmation dialog box will make sure that there is no unwanted clicks on the pause button and same can be implemented for resuming the recording just as precautionary action

kushagra20251 commented 1 year ago

respected sir, The following PR contains changes for both issue 6 and issue 21. Kindly review If there is any modification required. Thank you

uehaj2022 commented 1 year ago

The following PR contains changes for both issue 6 and issue 21. Kindly review If there is any modification required. Thank you

it is not ideal to combine two issues. Can you separate PR for each issues?

kushagra20251 commented 1 year ago

respected sir, I pushed changes from forked branch and it contains fully updated code for both issue. I did that on purpose since changes are only UI based they can be resolved using one issue. If it is not suitable then I remove this issue and make a new one with only changes for issue 21 only. awaiting for a response. thanks and regards

kushagra20251 commented 1 year ago

kindly, ignore this closed PR as it contained both the issues 6 and 21. There is another PR with same names for the individual changes

uehaj2022 commented 1 year ago

kindly, ignore this closed PR as it contained both the issues 6 and 21. There is another PR with same names for the individual changes

Thank you for your response. We understand.