diegoveloper commented 2 years ago

:scroll: Description

This change keeps the initial model after we re-open the feedback widget.

:bulb: Motivation and Context

When we select an initial mode, let say Navigation, every time we open the feedback widget that mode should be selected but it wasn't working in that way, the last mode selected remains even after we re-open the widget.

:green_heart: How did you test it?

A new unit test was added in feedback_test.
If you want to reproduce the issue: set the mode NAVIGATION, open the feedback widget, select DRAW, close and open again. You will see the DRAW remains active.

:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (3a38a88) into master (fb0938b) will increase coverage by 0.89%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   83.29%   84.18%   +0.89%     
==========================================
  Files          20       20              
  Lines         467      468       +1     
==========================================
+ Hits          389      394       +5     
+ Misses         78       74       -4

Impacted Files	Coverage Δ
feedback/lib/src/feedback_widget.dart	`90.99% <100.00%> (+3.71%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb0938b...3a38a88. Read the comment docs.

diegoveloper commented 2 years ago

hey @ueman , do you have an estimated date for a new version containing this fix?

ueman commented 2 years ago

@diegoveloper Thanks for reminding me! I'll try to do a release sometime later today.

ueman / feedback