search

ueman / feedback

A simple widget for getting better feedback.
https://pub.dev/packages/feedback
400 stars 98 forks source link

Leverage DraggableScrollabeController Once It's Available #150

Closed caseycrogers closed 1 year ago

caseycrogers commented 2 years ago

When #149 goes in, developers using the expandable bottom sheet feature will have to use FeedbackSheetDragHandle in the feedback sheet builder to provide a visual drag handle for users.

This is pretty clunky, but the only way to do it because the drag handle needs to be placed as a fixed header on top of their scrollable widget in order for users to be able to click and drag on it to drag the sheet. Once DraggableScrollableSheet supports programmatic control in production (see: https://github.com/flutter/flutter/pull/92440) we can pull the drag handle out of the builder so that developers don't have to provide it.

Additionally, the feedback_widget uses a value notifier internally to manage sheet related animations. This can also be replaced by referencing the controller directly assuming the controller is made a ChangeNotifier.

kamami commented 2 years ago

Any updates to this?

ueman commented 2 years ago

DraggableScrollabeController will probably be included in the next Flutter version. There's no date for that yet, but I expect it to be around February or March.

kamami commented 2 years ago

Is already on master and fully functional?

ueman commented 2 years ago

I'm not sure what you're referring to. flutter/flutter#92440 is already on master and fully functional. This library however doesn't yet support it.

kamami commented 2 years ago

Thanks for your response! I missed that this is a separate package...

quoc-huynh-cosee commented 1 year ago

Any updates on this? I need to expand the sheet programatically.

ueman commented 1 year ago

Closed via https://github.com/ueman/feedback/pull/239