sils commented 2 years ago

This way, when inheriting from the class, one can simply set _supportedLocales without having to override load().

:scroll: Description

Should theoretically make implementing translations easier and with less boilerplate code.

:bulb: Motivation and Context

Remove the load() function from https://github.com/ueman/feedback/issues/160#issuecomment-1018361157

:green_heart: How did you test it?

I didn't :)

:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

codecov[bot] commented 2 years ago

Codecov Report

Merging #171 (fc9cacc) into master (296b4e1) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          21       21           
  Lines         654      654           
=======================================
  Hits          539      539           
  Misses        115      115

Impacted Files	Coverage Δ
feedback/lib/src/l18n/translation.dart	`45.61% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 296b4e1...fc9cacc. Read the comment docs.

ueman commented 2 years ago

LGTM

ueman / feedback