ueman / feedback

A simple widget for getting better feedback.
https://pub.dev/packages/feedback
392 stars 94 forks source link

Simplify translations #172

Closed sils closed 2 years ago

sils commented 2 years ago

:scroll: Description

Simplify translations

:bulb: Motivation and Context

Less boilerplate code.

:green_heart: How did you test it?

Not yet.

:pencil: Checklist

:crystal_ball: Next steps

codecov[bot] commented 2 years ago

Codecov Report

Merging #172 (e0c7d15) into master (12942cc) will increase coverage by 0.09%. The diff coverage is 100.00%.

:exclamation: Current head e0c7d15 differs from pull request most recent head 1ad76ec. Consider uploading reports for the commit 1ad76ec to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   82.41%   82.51%   +0.09%     
==========================================
  Files          21       21              
  Lines         654      652       -2     
==========================================
- Hits          539      538       -1     
+ Misses        115      114       -1     
Impacted Files Coverage Δ
feedback/lib/src/l18n/translation.dart 45.45% <100.00%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a92aef7...1ad76ec. Read the comment docs.

ueman commented 2 years ago

I can't push to your fork, so continued at https://github.com/ueman/feedback/pull/175