Closed bgetsug closed 2 years ago
Merging #181 (1a4441c) into master (6af6b7f) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 82.36% 82.41% +0.05%
==========================================
Files 21 21
Lines 652 654 +2
==========================================
+ Hits 537 539 +2
Misses 115 115
Impacted Files | Coverage Δ | |
---|---|---|
feedback/lib/src/better_feedback.dart | 97.77% <ø> (+2.22%) |
:arrow_up: |
feedback/lib/src/feedback_bottom_sheet.dart | 81.96% <100.00%> (+0.30%) |
:arrow_up: |
feedback/lib/src/l18n/translation.dart | 42.85% <0.00%> (-0.78%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f973386...1a4441c. Read the comment docs.
:scroll: Description
Changed the
OnSubmit
typedef
to return aFuture<void>
instead of justvoid
.:bulb: Motivation and Context
I'm using a custom feedback sheet via
BetterFeedback.feedbackBuilder
and would like to be able to display a loading indicator while awaiting submission to complete. Otherwise, the UI sits on the feedback screen with no visible activity until submission completes. To the user, this may feel like the app has frozen momentarily.:green_heart: How did you test it?
bool isSubmitting
.OnSubmit
is passed to my feedback widget fromFeedbackBuilder
. A "Submit" button is displayed at the bottom of the sheet, which changes to a loading indicator whenisSubmitting
istrue
. It contains anonPressed
similar to the following:flutter test
:pencil: Checklist