ueman / feedback

A simple widget for getting better feedback.
https://pub.dev/packages/feedback
400 stars 98 forks source link

fix: don't replace existing MediaQuery widget #193

Closed Vinzent03 closed 2 years ago

Vinzent03 commented 2 years ago

:scroll: Description

Before wrapping the app widget in a new MediaQuery it's checking for an existing one. If there's already a `MediaQuery' Widget, it doesn't replace the old one.

:bulb: Motivation and Context

I don't add the BetterFeedback widget above the MaterialApp, instead in the builder from MaterialApp, because I'm using DevicePreview and ResponsiveFramework. They have to be above the BetterFeedback widget and manipulate the MediaQuery. So I changed this package to use the existing MediaQuery widget, if any.

:green_heart: How did you test it?

I have tested the changes manually in my own project.

:pencil: Checklist

Vinzent03 commented 2 years ago

Only the golden image test fails, with a diff of 0.26% and 0.34%, but it fails without my changes too.