search

ueman / feedback

A simple widget for getting better feedback.
https://pub.dev/packages/feedback
400 stars 98 forks source link

Dialog popping issue #205

Open bislerium opened 2 years ago

bislerium commented 2 years ago

Version

2.5.0

Library

feedback

Flutter channel

stable

Flutter version

3.0.3

Platform

Android

Details

I was trying to pop a dialog and it didn't pop, rather the backward scaffold popped.

I have two widget file for: setting page and logout FAB (main.dart). When the setting page is fully loaded, The function to logout is provided through a provider as callback/handler to the logout button > alert dialog > ok button. Without the use of Feedback, I am able to pop just to dialog. With the Feedback, The scaffold behind the dialog is pop

ping and the dialog remains intact. Direct implementation of Navigator.pop() in the dialog > ok button function works but using the callback from provider getter method, it's not working as expected.

https://user-images.githubusercontent.com/69395565/178547354-7c5a47a4-f20b-45a2-8c7f-ffa2e4f5ea57.mp4

Steps to reproduce

Output of flutter doctor -v

[√] Flutter (Channel stable, 3.0.3, on Microsoft Windows [Version 10.0.22000.778], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[√] Chrome - develop for the web
[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components      
[√] Android Studio (version 2021.2)
[√] VS Code (version 1.69.0)
[√] Connected device (4 available)
[√] HTTP Host Availability
gysipos commented 2 years ago

+1 We faced the exact same issue. Open dialog on back button press stays open and the underlying scaffold gets popped. feedback: ^2.5.0

ueman commented 2 years ago

Hey, are you open to fixing it and contributing it via PR?

gysipos commented 2 years ago

Hey!

Sorry, but at the moment we cannot allocate manpower for this task. We are not currently using the package, the issue came up when we were evaluating it for potential use.

On Thu, Oct 20, 2022 at 12:50 PM Jonas Uekötter @.***> wrote:

Hey, are you open to fixing it and contributing it via PR?

— Reply to this email directly, view it on GitHub https://github.com/ueman/feedback/issues/205#issuecomment-1285322590, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANCPT5BLMNOEAMZPFRECQX3WEEPV3ANCNFSM53LVRBTQ . You are receiving this because you commented.Message ID: @.***>

PLGuerraDesigns commented 8 months ago

I also faced issues with this package popping the page behind the dialog instead of the dialog itself. It seems to cause some interference with go_router. However, setting useRootNavigator in showDialog to false seemed to fix the issue.

IsaiasCuvula commented 8 months ago

I'm facing the same issue, as soon I added the package at the top level it messed up with my entire navigation system.

GoRouter - exception-no-go router-found-in-context showModalBottomSheet() only works if useRootNavigator: false, alerts dialogs not working properly.

I tried to manipulate but it just messed up, the package is amazing, for now, consider removing the package until it gets a little bit more stable.

JesusHdez960717 commented 7 months ago

Similar to #194

JesusHdez960717 commented 6 months ago

hi @gysipos, @IsaiasCuvula, @PLGuerraDesigns, and mainly @bislerium the initial creator of the issue the PR that solves this bug is finally merged (#293), if you want test it again with the latest version (3.1.0) to make sure and in case the bug is not reproduced any more, feel free to close this issue

gysipos commented 6 months ago

Cool, thanks for the headsup!