search

ueman / feedback

A simple widget for getting better feedback.
https://pub.dev/packages/feedback
387 stars 93 forks source link

State Restoration is entirely broken when BetterFeedback widget is used #213

Closed ozozozd closed 1 year ago

ozozozd commented 1 year ago

Version

2.5.0

Library

feedback

Flutter channel

stable

Flutter version

3.3.4

Platform

iOS

Details

Wrapping the main widget with BetterFeedBack breaks state restoration provided by the Navigator class.

Steps to reproduce

Output of flutter doctor -v

[✓] Flutter (Channel stable, 3.3.4, on macOS 12.5 21G72 darwin-arm, locale en-US)
    • Flutter version 3.3.4 on channel stable at /Users/oz/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eb6d86ee27 (7 weeks ago), 2022-10-04 22:31:45 -0700
    • Engine revision c08d7d5efc
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/oz/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.73.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (4 available)
    • Pixel 3 (mobile)           • 89WX0J4GG                            • android-arm64  • Android 12 (API 31)
    • iPhone 14 Pro Max (mobile) • D0708002-C678-43FB-B7FE-253A7D75F2CD • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1
      (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 12.5 21G72 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!
ozozozd commented 1 year ago

My state restoration still breaks intermittently despite having commented out the BetterFeedback widget.

Closed the issue.