ueman / feedback

A simple widget for getting better feedback.
https://pub.dev/packages/feedback
387 stars 93 forks source link

#38 Implement a dark mode #241

Closed apomalyn closed 10 months ago

apomalyn commented 11 months ago

:scroll: Description

Closes #38

Light mode (no changes) Screenshot 2023-10-03 at 10 36 52 AM
Dark mode πŸŒ™ Screenshot 2023-10-03 at 10 53 06 AM

:bulb: Motivation and Context

The package is currently stuck to light mode by default and needs the developers to implement their own dark mode which will not be perfect (the control panel will stay light). This PR fixes it!

By default, a dark mode will be provided and the developers can customize it and also control the [ThemeMode]!

:green_heart: How did you test it?

Added some golden tests to check the dark mode

:pencil: Checklist

:crystal_ball: Next steps

ueman commented 11 months ago

Thanks! This is awesome! I'll try to give a review tomorrow.

apomalyn commented 11 months ago

I updated my branch to get the latest changes, the workflow should pass now πŸ˜„

codecov[bot] commented 11 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (1fa9054) 85.87% compared to head (63cd12d) 84.10%. Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #241 +/- ## ========================================== - Coverage 85.87% 84.10% -1.78% ========================================== Files 20 20 Lines 616 648 +32 ========================================== + Hits 529 545 +16 - Misses 87 103 +16 ``` | [Files](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter) | Coverage Ξ” | | |---|---|---| | [feedback/lib/src/better\_feedback.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy9iZXR0ZXJfZmVlZGJhY2suZGFydA==) | `97.95% <100.00%> (+0.18%)` | :arrow_up: | | [feedback/lib/src/feedback\_bottom\_sheet.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy9mZWVkYmFja19ib3R0b21fc2hlZXQuZGFydA==) | `82.25% <100.00%> (+0.29%)` | :arrow_up: | | [feedback/lib/src/feedback\_controller.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy9mZWVkYmFja19jb250cm9sbGVyLmRhcnQ=) | `100.00% <ΓΈ> (ΓΈ)` | | | [feedback/lib/src/l18n/localization.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy9sMThuL2xvY2FsaXphdGlvbi5kYXJ0) | `91.66% <100.00%> (-0.65%)` | :arrow_down: | | [feedback/lib/src/theme/feedback\_theme.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy90aGVtZS9mZWVkYmFja190aGVtZS5kYXJ0) | `86.95% <100.00%> (+11.95%)` | :arrow_up: | | [feedback/lib/src/utilities/feedback\_app.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy91dGlsaXRpZXMvZmVlZGJhY2tfYXBwLmRhcnQ=) | `90.47% <90.90%> (-9.53%)` | :arrow_down: | | [...ack/lib/src/utilities/media\_query\_from\_window.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy91dGlsaXRpZXMvbWVkaWFfcXVlcnlfZnJvbV93aW5kb3cuZGFydA==) | `0.00% <0.00%> (-63.64%)` | :arrow_down: | | [feedback/lib/src/feedback\_widget.dart](https://app.codecov.io/gh/ueman/feedback/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Uek%C3%B6tter#diff-ZmVlZGJhY2svbGliL3NyYy9mZWVkYmFja193aWRnZXQuZGFydA==) | `91.25% <82.27%> (+0.34%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

apomalyn commented 11 months ago

πŸ‘‹ @ueman I'm going to check this evening to improve the code coverage. For the builds failing it seems like it's not related to my PR, but I can check to fix it if you want

ueman commented 10 months ago

Hey, thanks again, this is a great improvement. Sorry for the delay πŸ˜“