Closed apomalyn closed 10 months ago
Thanks! This is awesome! I'll try to give a review tomorrow.
I updated my branch to get the latest changes, the workflow should pass now π
Attention: 16 lines
in your changes are missing coverage. Please review.
Comparison is base (
1fa9054
) 85.87% compared to head (63cd12d
) 84.10%. Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
π @ueman I'm going to check this evening to improve the code coverage. For the builds failing it seems like it's not related to my PR, but I can check to fix it if you want
Hey, thanks again, this is a great improvement. Sorry for the delay π
:scroll: Description
ThemeMode
system to determine which theme to useCloses #38
Light mode (no changes)
Dark mode π
:bulb: Motivation and Context
The package is currently stuck to light mode by default and needs the developers to implement their own dark mode which will not be perfect (the control panel will stay light). This PR fixes it!
By default, a dark mode will be provided and the developers can customize it and also control the [ThemeMode]!
:green_heart: How did you test it?
Added some golden tests to check the dark mode
:pencil: Checklist
:crystal_ball: Next steps