feat: ✨ Gitlab onIssueCreated callback - Githubissues

ueman / feedback

A simple widget for getting better feedback.

https://pub.dev/packages/feedback

387 stars 93 forks source link

feat: ✨ Gitlab onIssueCreated callback #259

Closed viniciusamelio closed 8 months ago

viniciusamelio commented 8 months ago

:scroll: Description

Added a callback parameter to uploadToGitLab method

:bulb: Motivation and Context

Currently there is no way of listening or even knowing when the API call for issue creation was completed, so when i call showAndUploadToGitLab() I just don't have a practical way to hide a loader if needed, for example

:green_heart: How did you test it?

Adding an unit test to _feedback_gitlab/test/feedback_gitlabtest.dart

:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[x] I updated the docs if needed
[ ] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

It would be great to have something similar to this on feedback_sentry too

ueman commented 8 months ago

Hey, sorry I didn't yet come around to this yet. Is there no need for this anymore?

viniciusamelio commented 8 months ago

Actually what I needed can be done with feedbackBuilder already