search

ueno-llc / react-native-starter

Professional react-native starter kit with everything you'll ever need to deploy rock solid apps
https://ueno-llc.github.io/react-native-starter
MIT License
573 stars 89 forks source link

Upgrade to react-native-navigation v2? #180

Closed isaachinman closed 6 years ago

isaachinman commented 6 years ago

So it seems like react-native-navigation v2 is finally stable enough to be officially recommended by the maintainers.

Just wondering if a PR to upgrade this repo to v2 would be accepted.

birkir commented 6 years ago

What is coming in next release:

Currently RNNv2 is not stable enough for android in react-native 0.56, I'll be waiting for a PR to be merged there. Not saying I am a maintainer, but I do contribute a lot into RNN.

I'll be streamlining react-native-config so it will be less prune to errors. Refactor rename script so it will be more stable. Include mobx-state-tree with some UI specific stuff I'd like to ship with by default.

isaachinman commented 6 years ago

Great to hear you already have an upgrade planned. An unsolicited thought: adding things like TypeScript and mobx-state-tree as defaults would make this starter kit extremely opinionated. I get that it's primarily for internal use, but I think it would drive away some potential users.

Thanks again for maintaining a fantastic project!

birkir commented 6 years ago

Noted. Thanks Isaac.