Android project doesn't execute build-env.sh leading to stale environment variable values

ueno-llc / react-native-starter

Professional react-native starter kit with everything you'll ever need to deploy rock solid apps

https://ueno-llc.github.io/react-native-starter

MIT License

574 stars 90 forks source link

Android project doesn't execute build-env.sh leading to stale environment variable values #203

Closed dgobaud closed 5 years ago

dgobaud commented 5 years ago

The XCode project executes build-env.sh to make sure config.env.js is updated but the Android project doesn't seem to. Simple fix is to create a yarn android command eg "android": "yarn build:env && react-native run-android" but would be better to make the Android gradle projects execute build-env.sh

XCode link https://github.com/ueno-llc/react-native-starter/blob/master/ios/react-native-starter.xcodeproj/project.pbxproj#L100

jeremybarbet commented 5 years ago

Hey!

This is a good catch, it would be way better to have it in the android project. We will take a look at it!

jeremybarbet commented 5 years ago

Fixed with https://github.com/ueno-llc/react-native-starter/pull/210