search

ueno-llc / react-native-starter

Professional react-native starter kit with everything you'll ever need to deploy rock solid apps
https://ueno-llc.github.io/react-native-starter
MIT License
573 stars 89 forks source link

build scripts don't support [BUILD] and [NOBUILD] #204

Closed dgobaud closed 5 years ago

dgobaud commented 5 years ago

Documentation https://github.com/ueno-llc/react-native-starter/blob/master/docs/PUBLISHING.md image shows scripts looking for [BUILD] and [NOBUILD] tags in commit messages but scripts don't seem to do that

dgobaud commented 5 years ago

I tried adding below to android/build.gradle but it doesn't seem to execute the script and I can't figure out why

task buildEnv(type: Exec) {
    workingDir '../'

    commandLine './scripts/build-env.sh'
}
jeremybarbet commented 5 years ago

Hey! Sorry for the big delay.

You are totally right, [BUILD] and [NOBUILD] don't work. There is a simple reason for that, they are not part of any scripts anymore. We were using bitrise before, and this documentation was targeting the bitrise app. Since then we swiched to Appcenter, and we kept the same pipeline image and forget about this. We could take a look to bring them back into the appcenter-scripts-*

jeremybarbet commented 5 years ago

Hey!

I added this into this commit https://github.com/ueno-llc/react-native-starter/commit/8c7092a7ede1be41affe71a30436b8b0510afcab