Closed dgobaud closed 5 years ago
You are right, it's a bit of legacy with the first version of React native navigation that we had to patch before.
If I remember correctly, couple of files from the rename script are also undefined because of some legacy, no big deal here, but a clean would be really nice.
Don't hesitate to submit pull request if you already made changes on your side, I or Birkir will review it and merge it
done. curious what is difference in master and develop branch?
Looks good man.
develop is more like on-the-edge stuff where we introduce new things.
We try to keep master stable.
think below is unneeded - not entirely sure what it was for but I see the file is gone from current RNN code base https://github.com/wix/react-native-navigation/tree/master/lib/android/app/src/main/java/com/reactnativenavigation/react
I'm betting they used to have a common NavigationReactNativeHost.java file and have now specialized it based on the RN version so the
rm
is no longer needed?https://github.com/ueno-llc/react-native-starter/blob/b01e8d62ac75c2e748dda709191415ca837e6039/scripts/postinstall.sh#L4