search

ueno-llc / react-native-starter

Professional react-native starter kit with everything you'll ever need to deploy rock solid apps
https://ueno-llc.github.io/react-native-starter
MIT License
574 stars 90 forks source link

configure sentry to upload iOS/Android native debug symbols #214

Closed dgobaud closed 4 years ago

dgobaud commented 5 years ago

https://docs.sentry.io/clients/cocoa/dsym/

https://docs.sentry.io/clients/java/modules/android/

jeremybarbet commented 5 years ago

Do you mean you don't get any artifacts inside sentry? Did you check your logs to see if the symbols were uploaded?

dgobaud commented 5 years ago

JavaScript artifacts are uploaded but not the native ones.

JavaScript ones are uploaded here https://github.com/ueno-llc/react-native-starter/blob/master/appcenter-pre-build.sh#L56

birkir commented 5 years ago

Just add the required SENTRY_AUTH_TOKEN to your env file should work. Maybe .env is not working but just normal variables, like on CI etc.?

https://github.com/ueno-llc/react-native-starter/blob/master/ios/react-native-starter.xcodeproj/project.pbxproj#L195

dgobaud commented 5 years ago

That I think that uploads the React Native sourcemaps - not the native symbol files I'm talking about.

Looking here https://docs.sentry.io/clients/react-native/manual-setup/ I see what needs done I think under "Upload Debug Symbols to Sentry" at least for iOS (it missing Android instructions).

If you wish to upload the source maps and symbols to Sentry, create a new Run Script build phase with the following script:

export SENTRY_PROPERTIES=../sentry.properties

../node_modules/@sentry/cli/bin/sentry-cli upload-dsym
jeremybarbet commented 4 years ago

Hi! I will close this, since we upgrade the starter and we are now using latest version of sentry that have different integration