fix native app change detection for CodePush

ueno-llc / react-native-starter

Professional react-native starter kit with everything you'll ever need to deploy rock solid apps

https://ueno-llc.github.io/react-native-starter

MIT License

573 stars 89 forks source link

fix native app change detection for CodePush #217

Closed dgobaud closed 5 years ago

dgobaud commented 5 years ago

Think we just want to grab files changed between the last native push eg $LAST_IOS and the current commit $COMMIT_HASH which I think is what git diff --name-only $LAST_IOS..$COMMIT_HASH does.

the prior git rev-list -> git diff-tree was pulling out files that didn't actually change between the two commits but had reverted changes made to them. So in the process of getting to $LAST_IOS eg Podfile changed but we reverted the changes in the end so it didn't actually change.

birkir commented 5 years ago

Great. I want to make sure the command will produce the right results. Will test and then merge. Thanks!