search

ueno / ibus-skk

Japanese SKK engine for IBus
GNU General Public License v2.0
77 stars 19 forks source link

configure.ac message "Checking for IBUS_SKK" is confusing #41

Closed tamo closed 12 years ago

tamo commented 12 years ago

the configure script says "Checking for IBUS_SKK" which is surprising because ibus-skk doesn't require itself. (the chicken or the egg?)

so

PKG_CHECK_MODULES(IBUS_SKK, [ibus-1.0 >= 1.4.0 libskk], , AC_MSG_ERROR([can't find libskk]))

should be like this:

PKG_CHECK_MODULES(LIBSKK, [ibus-1.0 >= 1.4.0 libskk], , AC_MSG_ERROR([can't find libskk]))

or more accurately

PKG_CHECK_MODULES(LIBSKK, [libskk], , AC_MSG_ERROR([can't find libskk])) PKG_CHECK_MODULES(IBUS, [ibus-1.0 >= 1.4.0], , AC_MSG_ERROR([can't find ibus >= 1.4]))

or, you can skip your own error messages:

PKG_CHECK_MODULES(LIBSKK, [libskk]) PKG_CHECK_MODULES(IBUS, [ibus-1.0 >= 1.4.0])

ueno commented 12 years ago

OK, should be fixed in c08a5526908d9b55f2635d15def2bcc604b3cbe9