search

ueno / ibus-skk

Japanese SKK engine for IBus
GNU General Public License v2.0
77 stars 19 forks source link

Space is not handled if attempting to convert empty string #8

Closed iRi-E closed 14 years ago

iRi-E commented 14 years ago

Here is how to reproduce the problem:

(1) Turn IBus on with ibus-skk engine (2) Start conversion by typing Shift+q (3) Type space with preedit text empty ("▽")

The space key event is not handled, so the application incorrectly inserts a space character and causes a problem as I pointed out in issue #5.

ueno commented 14 years ago

Thanks. It should be fixed with ueno@2f1d2807fcaacd306758d37887ee3d4bb5355f87 and ueno@83b9524265083f58c09411da138e65d58277bacf.

The first commit fixes unicode handling error, and the second commit makes the behavior consistent with DDSKK (i.e. don't start conversion when preedit text is empty).

iRi-E commented 14 years ago

That seems to work fine. Thanks.