ueno / ruby-gpgme

a ruby interface to GnuPG Made Easy (GPGME).
GNU Lesser General Public License v2.1
232 stars 99 forks source link

Nokogiri 1.8.1 compatibility update #106

Closed rcclemente closed 6 years ago

rcclemente commented 6 years ago

Currently nokogiri 1.6.x has a vulnerability and Updating to 1.8.x is blocked due to the mini_portile2 compatibility.

gpgme (~> 2.0) was resolved to 2.0.14, which depends on
        mini_portile2 (~> 2.1)

nokogiri (= 1.8.1) was resolved to 1.8.1, which depends on
      mini_portile2 (~> 2.3.0)
coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.03%) to 90.44% when pulling 4595b42a4791e770d58bda655612d4d913222e8a on rcclemente:rclemente/Nokogiri_v1.8.1_compatible into f70d0268edbc361ac8e21968252fdf64f5f7feac on ueno:master.

rcclemente commented 6 years ago

🙏 please merge

dansketcher commented 6 years ago

@ueno Happy to release 2.0.15 if you want?

rcclemente commented 6 years ago

@dansketcher already tagged it only now needs a rake release

I currently don't have access for it 🙏

rake release
gpgme 2.0.15 built to pkg/gpgme-2.0.15.gem.
Tag v2.0.15 has already been created.
rake aborted!
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem. Ask an owner to add you with: gem owner gpgme --add  <myemai>
dansketcher commented 6 years ago

@rcclemente It's not the tagging that is the problem, that's fine. The question was to @ueno because it's not my name on the repo ;)

ueno commented 6 years ago

@dansketcher sure, thanks in advance

dansketcher commented 6 years ago

Released!