search

ueno / ruby-gpgme

a ruby interface to GnuPG Made Easy (GPGME).
GNU Lesser General Public License v2.1
232 stars 99 forks source link

added GPGME::Key.valid? method #133

Closed krtschmr closed 5 years ago

krtschmr commented 5 years ago

would add functionality for https://github.com/ueno/ruby-gpgme/issues/131

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.06%) to 88.81% when pulling e0ee34c32f295eca31b156f73c6a9fef2587532b on krtschmr:valid_key into f00a99f253d2244d40e0d92c1d41c273cbeadf26 on ueno:master.

dansketcher commented 5 years ago

Hi @krtschmr, would you be able to add a test or two for this one? Helps keep the coverage up :)

Cheers Dan

krtschmr commented 5 years ago

@dansketcher i've added a test for true and false. i bumped the version by a minor. if you don't like that let me know and i'll remove that commit so you can bump the version. thanks for merging.

krtschmr commented 5 years ago

@dansketcher can we please merge this?

dansketcher commented 5 years ago

Yeah drop out the version bump there, it needs to be done elsewhere as well, with the docs too. We can merge, just the day job keeping me busy ;)

krtschmr commented 5 years ago

@dansketcher added quick docs and removed the bump. thanks

alexjfisher commented 3 years ago

This doesn't just check whether a key is valid, but it also imports it if it is. If run on a block containing multiple keys, it will return false but have also imported all of the keys.

krtschmr commented 3 years ago

@alexjfisher urgh - now that you say it, makes sense 🤦🏿 do you happen to have an idea how to then just check a key?

krtschmr commented 1 year ago

This doesn't just check whether a key is valid, but it also imports it if it is. If run on a block containing multiple keys, it will return false but have also imported all of the keys.

is this still a problem?