ueno / ruby-gpgme

a ruby interface to GnuPG Made Easy (GPGME).
GNU Lesser General Public License v2.1
232 stars 99 forks source link

Update libgpg-error to fix build with gawk 5 #134

Closed Keruspe closed 4 years ago

Keruspe commented 5 years ago

Build is currently broken with gawk 5 because the version of libgpg-error which is bundled cannot be built with it. Downgrading to gawk 4.x "fixes" the problem. The issue is fixed upstream in https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9b6666b19072fbdf Updating libgpg-error to the latest release should be enough to fix this.

mashedkeyboard commented 5 years ago

Just encountered this problem while trying to upgrade an application from Ruby 2.5.3 to 2.5.7. Can this be merged in as a priority? cc @dansketcher :)

mashedkeyboard commented 5 years ago

Update: having just tested this in https://github.com/mashedkeyboard/ruby-gpgme/tree/patch-1, the latest release is too old to fix this. A new libgpg-error release needs to be produced.

mrohnstock commented 5 years ago

@mashedkeyboard apply the following upstream patch and it should work:

https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9b6666b19072fbdf

//edit: whoops nevermind, didn't read the whole message from @Keruspe

samgranieri commented 4 years ago

I would also like a new release of this gem. Right now I have to install gnupg, libgpg-error, and libassuan from homebrew and install this gem using system libraries.

laurent-indermuehle commented 4 years ago

There is a libgpg-error 1.37 beeing prepared: https://dev.gnupg.org/T4772

dansketcher commented 4 years ago

Good stuff thanks all for staying on this, your support is appreciated ❤️

dansketcher commented 4 years ago

Ok version is out, branch lib_version_upgrades_202002 tracks the change https://github.com/ueno/ruby-gpgme/compare/lib_version_upgrades_202002 Please test!

@ueno FYI proposing lib update

HarlemSquirrel commented 4 years ago

Working well for me so far on Arch Linux with Ruby 2.7.0

dansketcher commented 4 years ago

@samgranieri @Keruspe @mashedkeyboard could you also check out the lib_version_upgrades_202002 branch and let me know how you go? Thanks :)

Keruspe commented 4 years ago

@dansketcher Activating libgpg-error 1.37 (from /tmp/ruby-gpgme/ports/x86_64-pc-linux-gnu/libgpg-error/1.37)... => Works ike a charm, thanks

dansketcher commented 4 years ago

No (bad) news then....

dansketcher commented 4 years ago

https://rubygems.org/gems/gpgme/versions/2.0.20