search

ueno / ruby-gpgme

a ruby interface to GnuPG Made Easy (GPGME).
GNU Lesser General Public License v2.1
232 stars 99 forks source link

Switch to use mini_portile2 for building native libraries #74

Closed taonic closed 8 years ago

taonic commented 8 years ago

One of the major enhancements in mini_portile2 is to take configure_options literally without running in subshell, see: https://github.com/flavorjones/mini_portile/commit/e77b90938828980e670278e1c3bf83a62515a7fd.

The compatibility fix has been made at: https://github.com/ueno/ruby-gpgme/commit/661739705e7f63934e68f6b91115227fa309fb38. Unfortunately this breaks build with mini_portile < 0.7 (currently >= 0.5.0 in gemspec) when ENV['CFLAGS'] is present.

A gemspec dependency update seems to be necessary. But instead of depending any of the 0.7.0.rc* release, let's go straight into v2.

ueno commented 8 years ago

thanks!

taonic commented 8 years ago

@ueno Thanks for the merge. Shall we have a new release? I guess there are other people running into issues like: https://github.com/ueno/ruby-gpgme/issues/75

ueno commented 8 years ago

sure, done

taonic commented 8 years ago

@ueno :trophy: