search

ueokande / vim-vixen

Accelerates your web browsing with Vim power!!
https://ueokande.github.io/vim-vixen/
MIT License
2.11k stars 137 forks source link

Add ability to disable conflicting keybindings for some websites #1392

Open IzhakJakov opened 2 years ago

IzhakJakov commented 2 years ago

I'm opening this issue because:

Description

I would like to be able to disable keybindings on some websites that conflict with Vixen As shown in the PR for videospeed extension.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Go to www.youtube.com
  2. Play a video
  3. Go down to read comments by using J
  4. The video should now rewind 10secs as documented here

System configuration

ouuan commented 2 years ago

https://ueokande.github.io/vim-vixen/blacklist.html

IzhakJakov commented 2 years ago

Thank you for you post @ouuan but I am not looking for disabling the plugin on certain websites. What I would like to do is disable the keybindings on certain websites that conflict with Vixen.

Similar to what the extension Video Speed Controller is doing when using "Disable website key bindings" image

ouuan commented 2 years ago

Isn't Vim Vixen already overriding the website's keybindings when there are conflicts?

IzhakJakov commented 2 years ago

Not in the example I provided. You can checkout "Steps to Reproduce". Maybe there is something I am suppose to enable?

ouuan commented 2 years ago

Not in the example I provided. You can checkout "Steps to Reproduce".

I'm also able to reproduce it. However, on most sites except Youtube, the website's keybindings are overridden.

IzhakJakov commented 2 years ago

I had this issue in other websites as well Can you provide an example website where these keybindings are overwritten?

ouuan commented 2 years ago

Can you provide an example website where these keybindings are overwritten?

GitHub is an example.

IzhakJakov commented 2 years ago

Which keybindings are overwritten?

ouuan commented 2 years ago

Which keybindings are overwritten?

Press "?" to see the list. I think all conflicts are overridden. j, k, t, for example.

IzhakJakov commented 2 years ago

Nice, I was not aware of ? 😃 Also good example. Thank you!

I wonder why it does not disable YT's annoying keybindings 🤨