jessarcher
commented
2 years ago For anyone that wants to try this, you can build my branch as follows. You will need Git, Node, Yarn, and a Firefox edition that supports unsigned addons. Make sure you understand the risks before continuing.
git clone git@github.com:jessarcher/vim-vixen.git
cd vim-vixen
git checkout fix-console-bg
yarn install
yarn packageThis should create a vim-vixen-1.2.4.zip file in this directory which you can install from about:addons.
Again, only do this if you understand and accept the risks of enabling unsigned addons and always compile from source!
ditsuke
danjones1618
jsoo1
cdbrkfxrpt
LordPax
johalun
xeruf
jman-schief
applejag
weilbith
toastal
fosskers
ryanisnan
codeDude64
nattyg93
victorz
kotval
fpf3
jiriks74
This PR fixes the following issue where the console iframe is not transparent on sites that specify a
color-scheme, such as GitHub:The issue is caused by a change in Firefox where it will now make iframes opaque if their
color-schemediffers from the parent page. The Vim Vixen iframe currently doesn't specify acolor-scheme, but sites like GitHub do, hence the issue.See https://bugzilla.mozilla.org/show_bug.cgi?id=1738380 and https://fvsch.com/transparent-iframes
This PR makes two changes to solve this:
1. Set the appropriate
color-schemeon the console.The
ConsoleFramePresentergets the computedcolor-schemefor the<body>tag where the<iframe>will be injected and passes it to the console page via a query string parameter.The console page takes the query string parameter and updates the
colorSchemestyle property on the root element.While this does fix the issue once the page has loaded, the white overlay is still briefly visible while it's loading.
I tried several methods to set the
color-schemebut this was the only way I could set the value with the cross-origin of the<iframe>. I'm open to alternatives.2. Shrink the
<iframe>when not in use.To hide the white overlay while the page is loading, I've set the initial height of the
<iframe>to0px. TheuseAutoResizehook already sets the correct height on the<iframe>once the user triggers it.While not strictly necessary, I've also set the
<iframe>height back to0pxwhen the console is closed. This solves a minor issue I've had during web development where the browser element selector will highlight the invisible Vim Vixen<iframe>at the bottom of the page which makes it hard to select items underneath it.The shrinking of the
<iframe>makes setting thecolor-schemealmost unnecessary. However, I've left it for a few reasons:Fixes #1424 Fixes #1429 Fixes #1433