ueokande / vim-vixen

Accelerates your web browsing with Vim power!!
https://ueokande.github.io/vim-vixen/
MIT License
2.11k stars 138 forks source link

Does not work with Etherpad #249

Open hugoroy opened 6 years ago

hugoroy commented 6 years ago

I'm opening this issue because:

Description

I blacklist domains where I use etherpads, but Vim Vixen still interferes in actually typing text into etherpad.

Failure Information (for bugs)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Blacklist a domain with etherpad, e.g. *.framapad.org
  2. Go to an etherpad on a blacklisted domain, e.g. https://mensuel.framapad.org/p/j5YwrTwrcE and try to type text (e.g. press a key that would normally do something with Vim Vixen)
  3. Vim Vixen will interfere instead of complying with the blacklist and therefore Vim Vixen interferes with typing text into Etherpad.

System configuration

Console logs

Any relevant log in developer tools: N/A

hugoroy commented 6 years ago

This already came up in #173 but does not provide a fix. (Disableing Vim Vixen altogether is not an acceptable fix)

sukima commented 6 years ago

I can confirm this is also the case for codepen.io. It appears that the blacklist feature is ignored in these cases. Also of note Shift+Esc does not appear to work either.

Speculation: Vim Vixen is not actually being disabled like the documentation suggests. Perhaps a UI indicator would help distinguish if this is the case or not.

To reproduce in codepen.io:

Setup

  1. Open codepen.io
  2. Login/create new account
  3. Click user avatar and select Settings
  4. Select Vim as the Key Bindings.
  5. Click Save All Settings

Control (default config)

  1. Login to codepen.io
  2. Create new pen
  3. click an editing frame to give it focus
  4. Type i and enter text
  5. Press Esc
  6. Verify window has lost focus (expected: window does not loose focus)

Perform the same above with the addon disabled and you will see the window keeps focus.

Steps with temporary disabling

  1. Login to codepen.io
  2. Create new pen
  3. Press Shift+Esc
  4. click an editing frame to give it focus
  5. Type i and enter text
  6. Press Esc
  7. Verify window has lost focus (expected: window does not loose focus)

Steps with blacklist disabling

  1. Open Vim Vixen preferences.
  2. Add codepen.io to blacklist (See example config below)
  3. Close addon preferences tab
  4. Login to codepen.io
  5. Create new pen
  6. click an editing frame to give it focus
  7. Type i and enter text
  8. Press Esc
  9. Verify window has lost focus (expected: window does not loose focus)

Sample blacklist config

{
  "keymaps": { ... },
  "search": {
    "default": "duckduckgo",
    "engines": { ... }
  },
  "blacklist": [
    "codepen.io"
  ]
}
mvhulten commented 5 years ago

Issue confirmed for *.framapad.org in Vim Vixen 0.19.

xeruf commented 3 years ago

Blacklisting does work for me, still Vim Vixen should automatically pass keys through if I am in a textfield like that.