search

ueokande / vim-vixen

Accelerates your web browsing with Vim power!!
https://ueokande.github.io/vim-vixen/
MIT License
2.11k stars 137 forks source link

[minor] search for search engine names #305

Open thiswillbeyourgithub opened 6 years ago

thiswillbeyourgithub commented 6 years ago

I'm opening this issue because:

Description

In the :t or :o commands, say my default search engine is qwant and I want to search for google, I actually mean it : search for the name of the company google. It will load the engine google with an empty keyword strings instead of giving me the qwant result for the keyword google.

This can also cause issue with some search engines that return 404 when you try to search for nothing. (I can provide examples of this with searx if needed).

Steps to Reproduce

(another example is shown here)

  1. set duckduckgo as your default search engine
  2. set qwant as your second search engine
  3. in vimvixen type :o qwant and instead of having a duckduckgo page about qwant you'll end up with loading an empty qwant page.

System configuration

AlexeySachkov commented 6 years ago

Possible workaround (at least works for me): to search "google" when you have search engine named google you need to add quotes: type :t "google"

thiswillbeyourgithub commented 6 years ago

@AlexeySachkov that's right, I didn't notice, also one could also change his engine names in vimvixen to something slightly off like "goog" and this would not happen. But that's still a bug in my opinion.

And if someone thinks that it's the expected behavior and not a bug, please notice that you won't endup at (example with google) https://google.com/ but at https://google.com/search?q= which for google is fine (it redirects on its own) but some other engines might return 404.