search

ueokande / vim-vixen

Accelerates your web browsing with Vim power!!
https://ueokande.github.io/vim-vixen/
MIT License
2.11k stars 137 forks source link

Can't make a video fullscreen on youtube #618

Open Mati20187 opened 5 years ago

Mati20187 commented 5 years ago

I'm opening this issue because:

Description

When I try to make a video fullscreen on youtube using a vim shortcut (in my case it's F+Y), nothing happens. I have to use my mouse in order to make the video fullscreen. Also, when I try to use Vim keys in youtube, the youtube key bindings are often also activated, i.e. when I press F, there's a chance that the video will be maximized and the vim shortcuts will be shown, or only the shortcuts will show, but after pressing the one responsible for maximizing, nothing will happen.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Open a video on YouTube
  2. Try to maximize the video using F + the key shown in the lower right corner of the video

System configuration

ueokande commented 5 years ago

duplicated #202

Mati20187 commented 4 years ago

Not really a duplicate. I think that there's generally a problem with maximizing videos in vim vixen.

I've tried making videos fullscreen using f + letter shown next to the "fullscreen" button on YouTube, Bitchute and Vimeo and nothing happened. I hope you understand what I mean.

ueokande commented 4 years ago

@Mati20187 I have grasped your problem. That is security reason. We can see the following message when we click the full screen button by Vim Vixen:

Request for fullscreen was denied because Element.requestFullscreen() was not called from inside a short running user-generated event handler.

The full-screen button is activated only by user-generated event. That means click or press key manually to enter full screen mode. Vim Vixen invokes JavaScript method (element.click()) to click a button. So it cannot activate full-screen button.

I reopen the issue, but I cannot deal with it now.

J053Fabi0 commented 4 years ago

Any workaround this? I really hate when pressing f in YouTube and a bunch of yellow letters appear all over the video.